fix(ssm): correctly deduplicate parameter names #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter names with '/' in them would not be correctly deduplicated, since the '/' is also used to delimit identifiers in construct paths. Add protection in core to not allow construct identifiers to be created with '/' in them, as tryFindChild() would not be able to find it anymore. Fixes #3076.
ghost
requested a review
from 
eladb
approved these changes
Jul 3, 2019
| */ | ||
| function sanitizeId(id: string) { | ||
| // Escape path seps as double dashes | ||
| return id.replace(/\//g, '--'); |
…bs/aws-cdk into huijbers/slashes-in-construct-name
Kaixiang-AWS
pushed a commit
to Kaixiang-AWS/aws-cdk
that referenced
this pull request
Jul 3, 2019
Parameter names with '/' in them would not be correctly deduplicated, since the '/' is also used to delimit identifiers in construct paths. Change findChild() so it no longer traverses into the tree; if we assume it will only ever find one child deep, we can do the same kind of escaping there as we apply to construct IDs. Fixes aws#3076. BREAKING CHANGE: `construct.findChild()` now only looks up direct children
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter names with '/' in them would not be correctly deduplicated,
since the '/' is also used to delimit identifiers in construct paths.
Change
findChild()so it no longer traverses into the tree; if we assume itwill only ever find one child deep, we can do the same kind of escaping
there as we apply to construct IDs.
Fixes #3076.
BREAKING CHANGE:
construct.findChild()can only find direct children anymore.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license